Repository navigation
feat(integriq): build messaging-sms-providers-and-notifynl-mail - #3563
Merged
rubenvdlinde merged 1 commit intoNov 14, 2026
Merged
rubenvdlinde merged 1 commit into
rubenvdlinde merged 1 commit into
Conversation
… ci] Adds the SMS provider registry, the CM.com, MessageBird and Twilio bindings over the credential broker, and the refusal of an unknown provider value, plus one demo message per new provider. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 14, 2026 07:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds part of
openspec/changes/messaging-sms-providers-and-notifynl-mail(result: partial).Tasks done
SmsProviderRegistryholds every SMS binding by provider id.SmsDispatchService::resolveProvider()asks it: no value is the log binding, and a value no binding answers to (for exampletwillio) resolves toUnknownSmsProvider, which refuses the send naming the value, so the message is storedfailedwith that reason instead of reported as sent.CmComSmsProvider,MessageBirdSmsProviderandTwilioSmsProvideron a sharedBrokeredSmsProvider. Every call goes throughBrokeredCallService::prepare()anddispatch()as the Mollie binding does, and nothing leaves without acredentialRef. MessageBird and Twilio read status from the vendor. CM.com has no status read, so itsfetchStatus()refuses and says status arrives by callback.sms_messagerows, one per new provider, in the states sent, delivered and failed.Tasks left
GET /api/sms/providers,sms_message.sourceSlug), 6 (vendor delivery callbacks) and 7 (NotifyNL e-mail) did not fit in this run.Behaviour change
Tests
tests/validate-register.jspasses.Generated by Claude Code